-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto switching to read only mode #1052 #1056
Conversation
…ry version with not working tests.
…ot working tests.
...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java
Outdated
Show resolved
Hide resolved
...nagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/NodeDataProvider.java
Outdated
Show resolved
Hide resolved
...ment/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckScheduler.java
Outdated
Show resolved
Hide resolved
...ment/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckScheduler.java
Outdated
Show resolved
Hide resolved
import java.net.UnknownHostException; | ||
|
||
@Component | ||
class NodeDataProvider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have something similar: https://github.com/allegro/hermes/blob/master/hermes-common/src/main/java/pl/allegro/tech/hermes/common/util/InetAddressHostnameResolver.java. Maybe you can merge those two implementations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will not change it.
...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java
Outdated
Show resolved
Hide resolved
Looks like you need to rebase your changes on the latest master |
...ment/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckScheduler.java
Outdated
Show resolved
Hide resolved
...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java
Outdated
Show resolved
Hide resolved
...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java
Show resolved
Hide resolved
...nagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/NodeDataProvider.java
Outdated
Show resolved
Hide resolved
hermes-common/src/main/java/pl/allegro/tech/hermes/infrastructure/zookeeper/ZookeeperPaths.java
Outdated
Show resolved
Hide resolved
...ment/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckScheduler.java
Outdated
Show resolved
Hide resolved
...ment/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckScheduler.java
Outdated
Show resolved
Hide resolved
...ment/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckScheduler.java
Outdated
Show resolved
Hide resolved
...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java
Outdated
Show resolved
Hide resolved
...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java
Outdated
Show resolved
Hide resolved
...ment/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckScheduler.java
Show resolved
Hide resolved
...anagement/src/main/java/pl/allegro/tech/hermes/management/domain/health/HealthCheckTask.java
Outdated
Show resolved
Hide resolved
…ogging in HealthCheckScheduler
…t already in use
} | ||
} | ||
|
||
enum HealthCheckResult { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private?
…althCheckResult private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
squashed as 255680d |
No description provided.